-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Closed
Description
because it's creates new agents every request, for example:
var request = Request.forever({
maxSockets: 2
});
var r1 = request("http://google.com", function() {});
var r2 = request("http://google.com", function() {});
console.log(r1.agent === r2.agent); //prints false, but should be true
Problem is here https://github.com/request/request/blob/master/request.js#L486 .
This can be fixed by replacing this line by something like this:
self.agentClass = self.httpModule.Agent;
self.agentOptions.keepAlive = true;
Such behaviour makes sockets not reusable, because creates new pool(agent) every http request.
Metadata
Metadata
Assignees
Labels
No labels