8000 Add CallableDiscriminator and Tag by dmontagu · Pull Request #7983 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Add CallableDiscriminator and Tag #7983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 9 commits into from
Nov 1, 2023
Merged

Add CallableDiscriminator and Tag #7983

sydney-runkle merged 9 commits into from
Nov 1, 2023

Conversation

@dmontagu
Copy link
Contributor
@dmontagu dmontagu commented Oct 31, 2023

I think this should be preferred over #6915, mostly because the implementation there involves duplicating the list of types in the union, and generally seems more fragile.

I've opened as draft until docs/tests are added, hoping @sydney-runkle can help get this across the line tomorrow.

@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Oct 31, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: edccdde
Status: ✅  Deploy successful!
Preview URL: https://0dd7c17c.pydantic-docs2.pages.dev
Branch Preview URL: https://callable-discriminator-v2.pydantic-docs2.pages.dev

View logs

dmontagu
dmontagu commented Oct 31, 2023
View reviewed changes
dmontagu
dmontagu commented Oct 31, 2023
View reviewed changes
dmontagu
dmontagu commented Oct 31, 2023
View reviewed changes
dmontagu
dmontagu commented Oct 31, 2023
View reviewed changes
dmontagu
dmontagu commented Oct 31, 2023
View reviewed changes
@sydney-runkle sydney-runkle mentioned this pull request Nov 1, 2023
Closed
sydney-runkle
sydney-runkle reviewed Nov 1, 2023
View reviewed changes
dmontagu
dmontagu commented Nov 1, 2023
View reviewed changes
dmontagu
dmontagu commented Nov 1, 2023
View reviewed changes
dmontagu
dmontagu commented Nov 1, 2023
View reviewed changes
dmontagu
dmontagu commented Nov 1, 2023
View reviewed changes
dmontagu
dmontagu commented Nov 1, 2023
View reviewed changes
dmontagu
dmontagu commented Nov 1, 2023
View reviewed changes
dmontagu
dmontagu commented Nov 1, 2023
View reviewed changes
sydney-runkle and others added 2 commits November 1, 2023 13:37
@dmontagu dmontagu marked this pull request as ready for review November 1, 2023 19:59
sydney-runkle
sydney-runkle approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor
@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fast turnaround @dmontagu!

@sydney-runkle sydney-runkle merged commit 9868b45 into main Nov 1, 2023
@sydney-runkle sydney-runkle deleted the callable-discriminator-v2 branch November 1, 2023 21:37
@sydney-runkle sydney-runkle mentioned this pull request Nov 2, 2023
Closed
13 tasks
@samuelcolvin samuelcolvin mentioned this pull request Nov 5, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

relnotes-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmontagu @sydney-runkle
0