8000 feat(repo): use caching for pnpm workspaces in e2e tests by meeroslav · Pull Request #15461 · nrwl/nx · GitHub
[go: up one dir, main page]
Skip to content

feat(repo): use caching for pnpm workspaces in e2e tests #15461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2023
Merged

feat(repo): use caching for pnpm workspaces in e2e tests #15461

merged 2 commits into from
Mar 6, 2023

Conversation

meeroslav
Copy link
Contributor
@meeroslav meeroslav commented Mar 6, 2023 •
edited
Loading

Use workspace caching for pnpm as well.

This will significantly cut down on CI times.

We had it switched off, since there were some issues in the past for pnpm but that has been resolved a long time ago.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Mar 6, 2023
@vercel
Copy link
vercel bot commented Mar 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 6, 2023 at 2:37PM (UTC)

@nx-cloud
Copy link
Contributor
nx-cloud bot commented Mar 6, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 656fd46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@meeroslav meeroslav marked this pull request as ready for review March 6, 2023 10:53
@meeroslav meeroslav changed the title feat(repo): use caching for pnpm workspaces feat(repo): use caching for pnpm workspaces in e2e tests Mar 6, 2023
barbados-clemens
barbados-clemens requested changes Mar 6, 2023
View reviewed changes
@meeroslav meeroslav merged commit 82d499c into nrwl:master Mar 6, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
@meeroslav meeroslav deleted the cache-pnpm-cnw branch April 27, 2023 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barbados-clemens barbados-clemens barbados-clemens approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

Assignees

@meeroslav meeroslav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meeroslav @barbados-clemens
0