fix(core): prevent exclude method from overwriting previous calls #13614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5967bb56-11c2-444f-9474-e996881d3e45Details
💛 - Coveralls |
|
Can not use terminal to sudo |
|
Hello @ajlchiban, Thank you for your response. Did you mean that you couldn't use the terminal to run sudo commands in the CodeSandbox? I thought anyone could use the terminal to sudo by forking the public project. To avoid any confusion, I've added a minimum reproduction repository on GitHub as well. |
micalevisk
approved these changes
May 26, 2024
|
lgtm |
This was referenced Jun 29, 2024
This was referenced Sep 4, 2024
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Summary:
Previously, calling multiple
excludemethod inMiddlewareConsumeroverwrote the previously excluded routes.It only worked well when using a single
excludemethod.I created a minimum reproduction repository.
Both repositories contain the same code. You can review the test code (
exclude-middleware.spec.ts) and see the results by cloning or forking the repository and runningnpm run test.What is the new behavior?
This change ensures that the
excludemethod appends new routes to the existing excluded routes list instead of overwriting them.This preserves all previous exclude calls and maintains the intended behavior of accumulating excluded routes.
Does this PR introduce a breaking change?
Other information