Only set package data map under watch mode#46211
Merged
weswigham merged 1 commit intomicrosoft:mainfrom Oct 5, 2021
Merged
Conversation
1f624f3 to
f17c7fd
Compare
Member
|
Seems right. 👍 |
Member
|
@typescript-bot cherry-pick this to release-4.4 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.4 manually. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Oct 6, 2021
DanielRosenwasser
pushed a commit
that referenced
this pull request
Oct 6, 2021
DanielRosenwasser
pushed a commit
that referenced
this pull request
Oct 6, 2021
DanielRosenwasser
pushed a commit
that referenced
this pull request
Oct 6, 2021
DanielRosenwasser
added a commit
that referenced
this pull request
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since they're only used to make watchers in watch mode, the map can be left empty if the
watchflag is unset. While we should still take #46209 or #46208 (pending one or both of them fixing the perf issues) to improve watch mode perf, this change should limit the impact of the remainingrealpathcalls to only the mode they're actually needed for.