Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 6 files changed
- 6 contributors
Commits on Feb 17, 2021
-
fix: allow metadata keys to be cleared (#383)
Metadata keys can be cleared in the JSON API by setting the value to null; however this doesn't currently work through this library. This PR allows users to clear metadata keys by setting the value to None and documents how users should do this. Fixes #381
-
fix: correctly encode bytes for V2 signature (#382)
* fix: correctly encode bytes for V2 signature V2 signature was passing a string to the sign_bytes function instead of bytes. This works fine for most credentials (since their sign_bytes implementations accept strings) but not for impersonated credentials. V4 signature encodes the string before calling sign_bytes, so I do the same here. We should also look into clarifying the contract for the sign_bytes interface in the auth library. Fixes #373 * fix py2 failure
Commits on Feb 19, 2021
-
fix: allow signed url version v4 without signed credentials (#356)
* Fix: signed_url_v4 to accept credentials without private key. Preserve checks for efficiency in case of neither access_token nor service_account_email are provided. Fix: tests v4 with token to take into account not Signing credential class. * fix typo: 2 new lines before new test class * fix doc: Improve docstring to explain the use of the access_token AND the service_account_email, or the signer email. * fix: test coverage with the new IF branch * lint Co-authored-by: Tres Seaver <tseaver@palladion.com> Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com> Co-authored-by: Frank Natividad <franknatividad@google.com>
4 people authoredFeb 19, 2021
Commits on Feb 23, 2021
-
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.36.0...v1.36.1