10000 fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release by busunkim96 · Pull Request #501 · googleapis/python-logging · GitHub
[go: up one dir, main page]
Skip to content

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release #501

merged 2 commits into from
Mar 16, 2022

Conversation

busunkim96
Copy link
Contributor

Allow google-api-core<3.0.0dev on previous release of library. Note that this PR is to a new protected branch v2, not main.

This will be followed by a release PR and is a step towards removing googleapis/google-cloud-python#10566

@busunkim96 busunkim96 requested review from a team as code owners March 11, 2022 00:27
@busunkim96 busunkim96 requested a review from parthea March 11, 2022 00:27
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 11, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Mar 11, 2022
@parthea parthea changed the title chore(deps): allow google-api-core v2 on v2 release fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release Mar 14, 2022
@arbrown arbrown assigned arbrown and unassigned daniel-sanche Mar 15, 2022
@arbrown arbrown merged commit 0c5d9aa into v2 Mar 16, 2022
@arbrown arbrown deleted the v2-api-core-pin branch March 16, 2022 16:46
@release-please release-please bot mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrown arbrown arbrown approved these changes

@parthea parthea parthea approved these changes

Assignees

@arbrown arbrown

Labels
api: logging Issues related to the googleapis/python-logging API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @arbrown @parthea @daniel-sanche
0