8000 use coalesce instead of join by askazakov · Pull Request #1882 · dotnet/BenchmarkDotNet · GitHub
[go: up one dir, main page]
Skip to content

use coalesce instead of join#1882

Merged
AndreyAkinshin merged 1 commit intodotnet:masterfrom
askazakov:use-coalesce-for-template
Oct 5, 2023
Merged

use coalesce instead of join#1882
AndreyAkinshin merged 1 commit intodotnet:masterfrom
askazakov:use-coalesce-for-template

Conversation

@askazakov
Copy link
Contributor
@askazakov askazakov commented Dec 30, 2021

simplify template.json

@timcassell
Copy link
Collaborator
timcassell commented Jul 19, 2023

Templates were updated in #2338. Is this still relevant? Also, what does coalesce do? I'm not familiar with the templates. @askazakov cc @YegorStepanov

@timcassell timcassell requested a review from YegorStepanov July 19, 2023 06:50
@askazakov
Copy link
Contributor Author
askazakov commented Jul 19, 2023 •
edited
Loading

Templates were updated in #2338. Is this still relevant? Also, what does coalesce do? I'm not familiar with the templates. @askazakov cc @YegorStepanov

Yes, it is still relevant. It's nothing but refactoring. Try to do a little bit more clean code.

Docs for coalesce is here https://github.com/dotnet/templating/wiki/Available-Symbols-Generators#coalesce (in short coalesce behaves like the C# ?? operator)

pr logic is something like

  • framework either set via parameters or empty by default
  • frameworkDefault depends only on app type (console or not)
  • frameworkValue = framework ?? frameworkDefault (if framework is set then use it's value, otherwise use frameworkDefault accordingly app type)

@askazakov askazakov force-pushed the use-coalesce-for-template branch from 237dbad to db482b4 Compare July 19, 2023 07:15
@askazakov
Copy link
Contributor Author
askazakov commented Jul 31, 2023

@timcassell @YegorStepanov any updates?

@timcassell
Copy link
Collaborator
timcassell commented Jul 31, 2023

Yegor is currently busy, he should be available to review this soon.

@askazakov
Copy link
Contributor Author
askazakov commented Oct 4, 2023

@timcassell @YegorStepanov any updates?

@timcassell
Copy link
Collaborator
timcassell commented Oct 4, 2023

@AndreyAkinshin Perhaps you could give this a look if @YegorStepanov isn't around?

@AndreyAkinshin AndreyAkinshin requested review from AndreyAkinshin and removed request for YegorStepanov October 5, 2023 13:27
@AndreyAkinshin AndreyAkinshin force-pushed the use-coalesce-for-template branch from db482b4 to 86913d1 Compare October 5, 2023 13:37
@AndreyAkinshin AndreyAkinshin merged commit 00628ab into dotnet:master Oct 5, 2023
@AndreyAkinshin AndreyAkinshin added this to the v0.13.9 milestone Oct 5, 2023
@AndreyAkinshin
Copy link
Member
AndreyAkinshin commented Oct 5, 2023

@askazakov thanks for the PR and sorry for such a late merge.

@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Merged
@dependabot dependabot bot mentioned this pull request Aug 20, 2025
Closed
@dependabot dependabot bot mentioned this pull request Sep 3, 2025
Closed
This was referenced Sep 17, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 24, 2025
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Sep 29, 2025
Closed
This was referenced Oct 24, 2025
Open
Closed
Closed
This was referenced Nov 3, 2025
Closed
Closed
Closed
This was referenced Nov 13, 2025
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Dec 3, 2025
Open
@dependabot dependabot bot mentioned this pull request Dec 10, 2025
Open
@dependabot dependabot bot mentioned this pull request Feb 5, 2026
Open
This was referenced Mar 6, 2026
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.13.9

Development

Successfully merging this pull request may close these issues.

3 participants

@askazakov @timcassell @AndreyAkinshin
0