8000 Revert "feat: add match named snapshot (#14045)" · jestjs/jest@372d6c5 · GitHub
[go: up one dir, main page]
Skip to content

Commit 372d6c5

Browse files
SimenBSimenB
committed
Revert "feat: add match named snapshot (#14045)"
This reverts commit ab13484.
1 parent aaf5315 commit 372d6c5

File tree

21 files changed

+49
-1562
lines changed

21 files changed

+49
-1562
lines changed

‎CHANGELOG.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
### Features
44

55
- `[jest-cli]` Include type definitions to generated config files ([#14078](https://github.com/facebook/jest/pull/14078))
6-
- `[jest-core, jest-circus, jest-reporter, jest-runner]` Added support for reporting about start individual test cases using jest-circus ([#14174](https://github.com/jestjs/jest/pull/14174))
76
- `[jest-snapshot]` Support arrays as property matchers ([#14025](https://github.com/facebook/jest/pull/14025))
8-
- `[jest-snapshot]` Add `toMatchNamedSnapshot` to bring snapshot support to concurrent mode ([#14045](https://github.com/facebook/jest/pull/14045))
7+
- `[jest-core, jest-circus, jest-reporter, jest-runner]` Added support for reporting about start individual test cases using jest-circus ([#14174](https://github.com/jestjs/jest/pull/14174))
98

109
### Fixes
1110

‎docs/ExpectAPI.md

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -744,16 +744,6 @@ You can provide an optional `propertyMatchers` object argument, which has asymme
744744

745745
You can provide an optional `hint` string argument that is appended to the test name. Although Jest always appends a number at the end of a snapshot name, short descriptive hints might be more useful than numbers to differentiate **multiple** snapshots in a **single** `it` or `test` block. Jest sorts snapshots by name in the corresponding `.snap` file.
746746

747-
### `.toMatchNamedSnapshot(snapshotName, propertyMatchers?)`
748-
749-
This ensures that a value matches the most recent snapshot. Check out [the Snapshot Testing guide](SnapshotTesting.md) for more information.
750-
751-
You can provide an optional `propertyMatchers` object argument, which has asymmetric matchers as values of a subset of expected properties, **if** the received value will be an **object** instance. It is like `toMatchObject` with flexible criteria for a subset of properties, followed by a snapshot test as exact criteria for the rest of the properties.
752-
753-
By setting the `snapshotName` explicitly (as opposed to letting Jest infer the name from context) it can be guaranteed to be consistent across test runs, whatever the context at the time of evaluation. Jest always appends a number at the end of a snapshot name.
754-
755-
Jest sorts snapshots by name in the corresponding `.snap` file.
756-
757747
### `.toMatchInlineSnapshot(propertyMatchers?, inlineSnapshot)`
758748

759749
Ensures that a value matches the most recent snapshot.
@@ -886,12 +876,6 @@ exports[`drinking flavors throws on octopus 1`] = `"yuck, octopus flavor"`;
886876

887877
Check out [React Tree Snapshot Testing](/blog/2016/07/27/jest-14) for more information on snapshot testing.
888878

889-
### `.toThrowErrorMatchingNamedSnapshot(snapshotName)`
890-
891-
Use `.toThrowErrorMatchingNamedSnapshot` to test that a function throws an error matching the most recent snapshot when it is called.
892-
893-
By setting the `snapshotName` explicitly (as opposed to letting Jest infer the name from context) it can be guaranteed to be consistent across test runs, whatever the context at the time of evaluation. Jest always appends a number at the end of a snapshot name.
894-
895879
### `.toThrowErrorMatchingInlineSnapshot(inlineSnapshot)`
896880

897881
Use `.toThrowErrorMatchingInlineSnapshot` to test that a function throws an error matching the most recent snapshot when it is called.

‎docs/SnapshotTesting.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,6 @@ More information on how snapshot testing works and why we built it can be found
5252

5353
:::
5454

55-
:::tip
56-
57-
The `toMatchSnapshot` matcher infers the name based on the test function context when the snapshot is evaluated. This can cause snapshots in tests that are run concurrently to have different names on each test run. If you want to guarantee consistent names, you can use the `toMatchNamedSnapshot` matcher.
58-
59-
:::
60-
6155
### Updating Snapshots
6256

6357
It's straightforward to spot when a snapshot test fails after a bug has been introduced. When that happens, go ahead and fix the issue and make sure your snapshot tests are passing again. Now, let's talk about the case when a snapshot test is failing due to an intentional implementation change.

‎e2e/__tests__/__snapshots__/toThrowErrorMatchingNamedSnapshot.test.ts.snap

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0