refactor!: lazy compilation middleware supports multiCompiler and use config from compiler instance #9828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CodSpeed Performance ReportMerging #9828 will not alter performanceComparing 🎉 Hooray!
|
241fc39 to
578a468
Compare
Member
|
@JSerFeng Can we fix the CI and get this PR merged? ❤️ |
0d9ba83 to
612de05
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for passing a MultiCompiler to the lazy compilation middleware, enabling per-compiler lazy compilation configurations and introducing new hooks in MultiCompiler.
- Updated middleware to handle both Compiler and MultiCompiler instances.
- Added new hooks (beforeCompile, shutdown) and corresponding API updates.
- Enhanced tests to cover multiCompiler lazy compilation scenarios.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack/src/builtin-plugin/lazy-compilation/middleware.ts | Updated middleware to accept MultiCompiler and process each compiler. |
| packages/rspack/src/MultiWatching.ts | Introduced invalidateWithChangesAndRemovals for multi watching. |
| packages/rspack/src/MultiCompiler.ts | Added new hooks and watching property to MultiCompiler. |
| packages/rspack/etc/core.api.md | Updated API definitions to reflect new MultiCompiler support. |
| packages/rspack-test-tools/tests/legacy-test/MultiCompiler.test.js | Added tests for multi-compiler lazy compilation. |
| packages/rspack-test-tools/src/plugin/lazy-compilation-test-plugin.ts | Modified plugin to support MultiCompiler parameter. |
| packages/rspack-cli/src/commands/serve.ts | Modified serve command to use lazy compilation middleware with MultiCompiler. |
| Others | Minor updates to test fixtures and API documentation. |
6dc6454 to
8304647
Compare
chenjiahan
reviewed
May 12, 2025
packages/rspack/src/builtin-plugin/lazy-compilation/middleware.ts
Outdated
Show resolved
Hide resolved
chenjiahan
reviewed
May 12, 2025
5ff046f to
ade0661
Compare
ade0661 to
2b855c7
Compare
chenjiahan
approved these changes
Jun 16, 2025
This was referenced Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lazy compilation middleware can receive multiCompiler as parameter
When there is a module triggers update, we notify the multiWatching, then multiWatching will invalidate its sub watching.
Every compiler can has its own lazy-compilation config, for example you can make compiler_1 only lazy compiles entries, while compiler_2 only lazy compiles imports
Checklist