8000 fix: should rebuild chunk outgoings when incremental runtime change by JSerFeng · Pull Request #10577 · web-infra-dev/rspack · GitHub
[go: up one dir, main page]
Skip to content

fix: should rebuild chunk outgoings when incremental runtime change #10577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahabhgk merged 1 commit into from
Jun 5, 2025
Merged

fix: should rebuild chunk outgoings when incremental runtime change #10577

ahabhgk merged 1 commit into from
Jun 5, 2025

Conversation

@JSerFeng
Copy link
Contributor
@JSerFeng JSerFeng commented Jun 5, 2025

Summary

When incremental rebuild, should rebuild chunk's outgoings once runtime changes

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
netlify bot commented Jun 5, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 0f2f3da
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68411e516c792c00082282dd

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr 8000 is created by the member of Rspack. labels Jun 5, 2025
@codspeed-hq
Copy link
codspeed-hq bot commented Jun 5, 2025

CodSpeed Performance Report

Merging #10577 will not alter performance

Comparing fix/incremental-code-spltting (0f2f3da) with main (596b3ef)

Summary

✅ 12 untouched benchmarks

@github-actions
Copy link
Contributor
github-actions bot commented Jun 5, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-06-05 0b4cbec) Current Change
10000_big_production-mode_disable-minimize + exec 35.3 s ± 407 ms 35.6 s ± 429 ms +1.02 %
10000_development-mode + exec 1.89 s ± 31 ms 1.84 s ± 192 ms -2.60 %
10000_development-mode_hmr + exec 757 ms ± 23 ms 744 ms ± 17 ms -1.69 %
10000_production-mode + exec 2.39 s ± 294 ms 2.27 s ± 134 ms -5.27 %
10000_production-mode_persistent-cold + exec 2.42 s ± 53 ms 2.4 s ± 26 ms -0.58 %
10000_production-mode_persistent-hot + exec 1.71 s ± 48 ms 1.73 s ± 178 ms +1.26 %
arco-pro_development-mode + exec 1.79 s ± 56 ms 1.79 s ± 130 ms +0.11 %
arco-pro_development-mode_hmr + exec 384 ms ± 4.2 ms 383 ms ± 1.1 ms -0.25 %
arco-pro_production-mode + exec 3.37 s ± 41 ms 3.48 s ± 65 ms +3.32 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.44 s ± 57 ms 3.61 s ± 285 ms +4.83 %
arco-pro_production-mode_persistent-cold + exec 3.47 s ± 109 ms 3.55 s ± 55 ms +2.23 %
arco-pro_production-mode_persistent-hot + exec 2.06 s ± 12 ms 2.14 s ± 45 ms +3.69 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.46 s ± 280 ms 3.48 s ± 117 ms +0.73 %
large-dyn-imports_development-mode + exec 2.12 s ± 14 ms 2.04 s ± 47 ms -3.56 %
large-dyn-imports_production-mode + exec 2.11 s ± 36 ms 2.06 s ± 37 ms -2.27 %
threejs_development-mode_10x + exec 1.43 s ± 80 ms 1.39 s ± 33 ms -2.97 %
threejs_development-mode_10x_hmr + exec 857 ms ± 13 ms 848 ms ± 32 ms -1.04 %
threejs_production-mode_10x + exec 4.72 s ± 62 ms 4.96 s ± 351 ms +4.89 %
threejs_production-mode_10x_persistent-cold + exec 4.84 s ± 339 ms 4.95 s ± 34 ms +2.25 %
threejs_production-mode_10x_persistent-hot + exec 4.27 s ± 280 ms 4.38 s ± 41 ms +2.55 %
10000_big_production-mode_disable-minimize + rss memory 9248 MiB ± 42.3 MiB 9144 MiB ± 69 MiB -1.12 %
10000_development-mode + rss memory 647 MiB ± 25.9 MiB 658 MiB ± 18.9 MiB +1.69 %
10000_development-mode_hmr + rss memory 794 MiB ± 21.7 MiB 780 MiB ± 4.43 MiB -1.71 %
10000_production-mode + rss memory 649 MiB ± 30.4 MiB 661 MiB ± 42.8 MiB +1.83 %
10000_production-mode_persistent-cold + rss memory 757 MiB ± 36.5 MiB 750 MiB ± 11.9 MiB -0.90 %
10000_production-mode_persistent-hot + rss memory 752 MiB ± 34 MiB 743 MiB ± 21.7 MiB -1.24 %
arco-pro_development-mode + rss memory 573 MiB ± 47.9 MiB 578 MiB ± 84.8 MiB +0.79 %
arco-pro_development-mode_hmr + rss memory 472 MiB ± 39.4 MiB 498 MiB ± 40.9 MiB +5.35 %
arco-pro_production-mode + rss memory 674 MiB ± 56.6 MiB 724 MiB ± 85.4 MiB +7.35 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 710 MiB ± 38.1 MiB 763 MiB ± 68.5 MiB +7.55 %
arco-pro_production-mode_persistent-cold + rss memory 786 MiB ± 65.5 MiB 799 MiB ± 51.2 MiB +1.67 %
arco-pro_production-mode_persistent-hot + rss memory 651 MiB ± 46.5 MiB 666 MiB ± 127 MiB +2.34 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 673 MiB ± 91.1 MiB 728 MiB ± 85.8 MiB +8.19 %
large-dyn-imports_development-mode + rss memory 654 MiB ± 5.9 MiB 660 MiB ± 8.64 MiB +0.98 %
large-dyn-imports_production-mode + rss memory 542 MiB ± 3.25 MiB 548 MiB ± 7.55 MiB +1.14 %
threejs_development-mode_10x + rss memory 595 MiB ± 16.3 MiB 600 MiB ± 7.03 MiB +0.90 %
threejs_development-mode_10x_hmr + rss memory 757 MiB ± 54.7 MiB 775 MiB ± 55.5 MiB +2.49 %
threejs_production-mode_10x + rss memory 868 MiB ± 25.4 MiB 871 MiB ± 11.9 MiB +0.28 %
threejs_production-mode_10x_persistent-cold + rss memory 940 MiB ± 22.6 MiB 958 MiB ± 55.1 MiB +1.90 %
threejs_production-mode_10x_persistent-hot + rss memory 827 MiB ± 50.5 MiB 854 MiB ± 27.4 MiB +3.24 %

@ahabhgk ahabhgk merged commit e32b7ed into main Jun 5, 2025
46 checks passed
@ahabhgk ahabhgk deleted the fix/incremental-code-spltting branch June 5, 2025 07:00
@renovate renovate bot mentioned this pull request Jul 1, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JSerFeng @ahabhgk
0