Bump versions of pre-commit hooks #3716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning[dependabot-cooldown]: insufficient cooldown in Dependabot updates --> ./.github/dependabot.yml:3:5 | 3 | - package-ecosystem: "github-actions" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing cooldown configuration | = note: audit confidence → High = note: this finding has an auto-fix
src/urllib3/util/request.py:231:13: F824 `nonlocal body` is unused: name is never assigned in scope src/urllib3/util/request.py:231:13: F824 `nonlocal blocksize` is unused: name is never assigned in scope
hugovk
reviewed
Nov 21, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
sigmavirus24
approved these changes
Nov 28, 2025
Contributor
|
Tip: you may want to enable https://pre-commit.ci/ for this repo to have automated updates of the hooks. It can also update PRs when there are fixes, which can save a bit of extra hassle. I also stick this at the bottom of the config so you only get autoupdates quarterly instead of the default weekly: ci:
autoupdate_schedule: quarterly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/urllib3/urllib3/actions/runs/19516465216/job/55869409115?pr=3715
There is a warning in the lint output that the isort step may stop working soon:
Additionally, my editor started reformatting some files with a newer version of black and isort causing noisy git diffs.
So I'm upgrading all pre-commit hooks related to Python here and applying suggested fixes.