8000 cmds/core/hohup: nohup command by binjip978 · Pull Request #2861 · u-root/u-root · GitHub
[go: up one dir, main page]

Skip to content

cmds/core/hohup: nohup command #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2024
Merged

cmds/core/hohup: nohup command #2861

merged 3 commits into from
Jan 30, 2024

Conversation

binjip978
Copy link
Contributor

No description provided.

Copy link
codecov bot commented Jan 19, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (5c5df9a) 77.32% compared to head (670a12b) 77.31%.

Files Patch % Lines
cmds/core/nohup/nohup.go 57.14% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
- Coverage   77.32%   77.31%   -0.02%     
==========================================
  Files         428      429       +1     
  Lines       43059    43094      +35     
==========================================
+ Hits        33295    33316      +21     
- Misses       9764     9778      +14     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.36% <57.14%> (-0.11%) ⬇️
integration/generic-tests/...-amd64 18.21% <ø> (ø)
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 21.80% <ø> (ø)
integration/gotests/...-amd64 74.14% <57.14%> (-0.02%) ⬇️
integration/gotests/...-arm 75.37% <57.14%> (-0.10%) ⬇️
integration/gotests/...-arm64 75.17% <57.14%> (+0.05%) ⬆️
pkg/...-amd64 76.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Jan 20, 2024
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@rminnich
Copy link
Member

I can actually use this command today :-)

@binjip978 binjip978 merged commit c5c7116 into u-root:main Jan 30, 2024
@binjip978 binjip978 deleted the nohup branch January 30, 2024 04:54
@binjip978
Copy link
Contributor Author

I can actually use this command today :-)

That's nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0