Keep body size limit for AMP redirects #62315
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for bug fixes". Cheers! Carsonbot |
|
The fix looks good to me, but we need to apply it in the 6.4 branch as that branch already disables the body size limit. |
5909b16 to
7f3e591
Compare
|
@stof Thanks for the pointer. I changed the base to 6.4 now. Note that this version still included just the one version of |
|
yes please. Edit: might not be worth it depending on how the merge-up will go. |
|
Thank you @villermen. |
| $request->setTcpConnectTimeout($originRequest->getTcpConnectTimeout()); | ||
| $request->setTlsHandshakeTimeout($originRequest->getTlsHandshakeTimeout()); | ||
| $request->setTransferTimeout($originRequest->getTransferTimeout()); | ||
| $request->setBodySizeLimit($originRequest->getBodySizeLimit()); |
There was a problem hiding this comment.
FTR I changed it this way after merging:
- $request->setBodySizeLimit($originRequest->getBodySizeLimit());
+ $request->setBodySizeLimit(0);
+ if (method_exists($request, 'setInactivityTimeout')) {
+ $request->setInactivityTimeout(0);
+ }|
Now merged into 7.3 |
Copies over body size limit when following redirects in
AmpHttpClient. See #62314