8000 Work around `parse_url()` bug by nicolas-grekas · Pull Request #58218 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Work around parse_url() bug #58218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

Work around parse_url() bug #58218

merged 1 commit into from
Sep 11, 2024

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Sep 10, 2024 •
edited by OskarStark
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52579, #54332
License MIT

Works around

@carsonbot carsonbot added this to the 5.4 milestone Sep 10, 2024
This was referenced Sep 10, 2024
Closed
Merged
Open
@OskarStark OskarStark changed the title Work around parse_url() bug Work around parse_url() bug Sep 11, 2024
@nicolas-grekas nicolas-grekas merged commit e35606b into symfony:5.4 Sep 11, 2024
8 of 12 checks passed
@nicolas-grekas nicolas-grekas deleted the parse-url branch September 11, 2024 06:59
@ajgarlag ajgarlag mentioned this pull request Sep 19, 2024
Closed
This was referenced Sep 21, 2024
Merged
Merged
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 12, 2024
Merged
nicolas-grekas added a commit that referenced this pull request Nov 13, 2024
@nicolas-grekas
bug #58836 Work around parse_url() bug (bis) (nicolas-grekas)
4b8695c 
This PR was merged into the 5.4 branch.

Discussion
----------

Work around `parse_url()` bug (bis)

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | #58313
| License       | MIT

This PR is a follow up of #58218

parse_url behaves incorrectly when parsing some URLs that don't contain `?` or `#`.
This PR ensures that one of those chars is always found when calling the function.

Commits
-------

80257ea Work around parse_url() bug (bis)
@renovate renovate bot mentioned this pull request Dec 9, 2024
Open
1 task
@richard67 richard67 mentioned this pull request Feb 1, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @OskarStark @derrabus @carsonbot
0