8000 Maintenance: Remove obsolete automigrations by valentinpalkovic · Pull Request #30945 · storybookjs/storybook · GitHub
[go: up one dir, main page]

Skip to content

Maintenance: Remove obsolete automigrations #30945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2025

Conversation

valentinpalkovic
Copy link
Contributor
@valentinpalkovic valentinpalkovic commented Mar 27, 2025

Closes #

What I did

Refactor automigration fixes for Storybook 9 compatibility. Updated version ranges for various fixes to support versions below 9.0.0 and added new checks for deprecated packages. Removed legacy code and tests related to previous versions, ensuring a cleaner migration path for users upgrading to Storybook 9

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR implements extensive cleanup and modernization of Storybook's codebase for version 9.0, removing obsolete automigrations, deprecated features, and updating version requirements.

  • Removes numerous obsolete automigration files and tests that were specific to pre-9.0 versions
  • Updates minimum Node.js requirement from 18.0.0 to 20.0.0 across all packages
  • Removes deprecated APIs including globals (replaced with initialGlobals), experimental sidebar types, and legacy icon formats
  • Updates framework requirements (Angular 18+, Next.js 14+) and drops Vite 4 support in favor of Vite 5/6
  • Consolidates type imports and removes deprecated parameters from various addons (e.g., a11y manual mode configuration)

…ersion ranges for various fixes to support versions below 9.0.0 and added new checks for deprecated packages. Removed legacy code and tests related to previous versions, ensuring a cleaner migration path for users upgrading to Storybook 9.
@valentinpalkovic valentinpalkovic changed the base branch from next to valentin/drop-tooling-support March 27, 2025 11:44
Copy link
nx-cloud bot commented Mar 27, 2025

View your CI Pipeline Execution ↗ for commit 2488ec1.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-30 10:28:58 UTC

Copy link
Contributor
@greptile-apps greptile-apps bot left a comme 8000 nt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

185 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@valentinpalkovic valentinpalkovic self-assigned this Mar 28, 2025
@valentinpalkovic valentinpalkovic added maintenance User-facing maintenance tasks ci:normal labels Mar 28, 2025
Base automatically changed from valentin/drop-tooling-support to next March 28, 2025 15:14
@valentinpalkovic valentinpalkovic merged commit 64a1c99 into next Mar 30, 2025
52 of 54 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/remove-obsolete-automigrations branch March 30, 2025 10:43
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automigrations ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0