Telemetry: Improve anonymous id calculation #29736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
- Paths were not stable between windows + unix - Remote URLs can be specified without the `.git` extension
3a705f3 to
8e0ef7f
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1cc488e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This was referenced Dec 2, 2024
Merged
yannbf
pushed a commit
that referenced
this pull request
Dec 5, 2024
Telemetry: Improve anonymous id calculation (cherry picked from commit 8bab9e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitextensionChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29736-sha-1cc488e7. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29736-sha-1cc488e7 sandboxor in an existing project withnpx storybook@0.0.0-pr-29736-sha-1cc488e7 upgrade.More information
0.0.0-pr-29736-sha-1cc488e7tmeasday/anonymous-id-tweaks1cc488e71732850075)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29736Greptile Summary
Improved anonymous ID calculation in Storybook's telemetry by normalizing paths across operating systems and standardizing git remote URL handling.
slashlibrary incode/core/src/telemetry/anonymous-id.tsfor consistent IDs between Windows and Unix.gitextension appending innormalizeGitUrl()for remote URLs missing the extensionanonymous-id.test.tsfor URL normalization and cross-platform path handlingunhashedProjectIdfunction for better testability and cleaner code organization💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!