Correctly expand query param with same name from URI variables array #34783
Closed
whlit wants to merge 2 commits intospring-projects:mainfrom
Closed
Correctly expand query param with same name from URI variables array #34783whlit wants to merge 2 commits intospring-projects:mainfrom
whlit wants to merge 2 commits intospring-projects:mainfrom
Conversation
Signed-off-by: whl <whlit.cola@gmail.com>
ba95cb0 to
0ae1fd2
Compare
Member
|
@whlit could you add a unit test for that? |
Contributor
Author
OK, I'll add it |
Signed-off-by: whl <whlit.cola@gmail.com>
Contributor
|
Thank you very much @whlit @bclozel @rstoyanchev |
rstoyanchev
pushed a commit
that referenced
this pull request
Apr 23, 2025
See gh-34783 Signed-off-by: whl <whlit.cola@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34781
For repeated fields, the original method is to overwrite them instead of adding them to the original array.