sigstore_rekor: clarify inclusion_promise requirement #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
protos/sigstore_rekor.proto
Outdated
| // Optional for >= v0.2 bundles, and SHOULD be verified when present. | ||
| // Also may be used as a signed timestamp. | ||
| // Optional for >= v0.2 bundles if another source of signed time | ||
| // is present. |
There was a problem hiding this comment.
One could interpret "another source of ... time" to be current time, but "current time" wouldn't be signed. We could be very prescriptive and say "When verifying long-lived certificates, the client MAY choose to not require a signed timestamp and instead use the system clock." Thoughts?
There was a problem hiding this comment.
That sounds good to me! Updating.
There was a problem hiding this comment.
Updated in d9edb63 -- it now talks about a "suitable" source of time, which can be either another signed time source or the current system time when the certs are long-lived. LMKWYT!
Signed-off-by: William Woodruff <william@trailofbits.com>
haydentherapper
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies the (expected) requirements around
inclusion_promiseslightly. In particular, it clarifies thatinclusion_promiseis optional if and only if another source of signed time is present. If no other source of signed time is present, then aninclusion_promiseis required and MUST be verified.For cross-referencing, this is the part of the Client spec that suggests this behavior:
(NB: Like the other requirements on bundle formats/required fields, this requirement is for short-lived certificate instances of Sigstore, like the Public Good Instance. CC @haydentherapper for thoughts on if/how this can be better communicated -- I'm happy to add additional language here or in the
sigstore_bundle.protofile!)