8000 Use hash in README instructions by pllim · Pull Request #54 · scientific-python/circleci-artifacts-redirector-action · GitHub
[go: up one dir, main page]

Skip to content

Use hash in README instructions #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

pllim
Copy link
Contributor
@pllim pllim commented Aug 12, 2024

Good security practice? 🤷‍♀️

@pllim pllim added the documentation Improvements or additions to documentation label Aug 12, 2024
@larsoner
Copy link
Collaborator

Maybe it would be better to add a comment suggesting to prefer hashes? Otherwise we'll have to keep updating this with each release, which is too easy to forget

@pllim
Copy link
Contributor Author
pllim commented Aug 12, 2024

OK, done. Thanks for review!

@larsoner larsoner merged commit 4e40163 into scientific-python:master Aug 12, 2024
@larsoner
Copy link
Collaborator

Thanks @pllim !

@pllim pllim deleted the use-hash branch August 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0