Do not group accessors having rbs-inline annotations in Style/AccessorGrouping
#13221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Sep 11, 2024
changelog/change_accessor_grouping_supports_rbs_inline_annotations.md
Outdated
Show resolved
Hide resolved
koic
reviewed
Sep 11, 2024
koic
reviewed
Sep 11, 2024
koic
reviewed
Sep 11, 2024
koic
reviewed
Sep 11, 2024
|
It would be good to add information about accepting RBS::Inline annotation comment to this cop's documentation. |
3cb1b30 to
fab576e
Compare
|
@koic Thank you for the quick and exact review! |
…sorGrouping` [RBS::Inline](https://github.com/soutaro/rbs-inline) is a utility to embed RBS type declarations into Ruby code as comments. This avoids to group accessors having RBS::Inline annotation comments in `Style/AccessorGrouping`. refs: https://github.com/soutaro/rbs-inline/wiki/Syntax-guide
fab576e to
ed8249f
Compare
|
Seems like a reasonable change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rbs-inline is a utility to embed RBS type declarations into Ruby code as comments.
This avoids to group accessors having rbs-inline annotation comments in
Style/AccessorGrouping.refs: https://github.com/soutaro/rbs-inline/wiki/Syntax-guide
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.