[DX] Enable polyfill rules on withPhpSets() config #5981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
commented
Jun 20, 2024
| StrEndsWithRector::class, | ||
| StrContainsRector::class, | ||
| ]); | ||
| }; |
There was a problem hiding this comment.
If anyone notices this set should be more complete, let us know 😉
samsonasik
reviewed
Jun 20, 2024
Comment on lines
+460
to
+461
| // make use of polyfill packages in composer.json | ||
| $this->sets[] = SetList::PHP_POLYFILLS; |
There was a problem hiding this comment.
I think this should be enabled manually via passed config, for example, we use withPhpSets(php53: true), it doesn't make sense to have str_starts_with() change? That will make too much change when it on step by step migration.
I think user needs to enable it by, eg: withPhpSets(php53: true, polyfill: true)
wdyt?
There was a problem hiding this comment.
I think add new method: withPhpPolyfill() can be the way to go
There was a problem hiding this comment.
Makes sense, thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polyfill rules are now enabled, once withPhpSets() is in the place. To pick up used packages in
composer.json👍Follow up to #5388