-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Closed
Labels
module: cpp-extensionsRelated to torch.utils.cpp_extensionRelated to torch.utils.cpp_extensionmodule: regressionIt used to work, and now it doesn'tIt used to work, and now it doesn'ttriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
When we compile the torch extension like SGLang does, we need to set py_limited_api=True
to maintain the compatibility between different python version, for example what the SGLang does https://github.com/sgl-project/sglang/blob/main/sgl-kernel/setup_cpu.py#L75C1-L85C2
ext_modules = [
Extension(
name="sgl_kernel.common_ops",
sources=sources,
include_dirs=include_dirs,
extra_compile_args=extra_compile_args,
libraries=libraries,
extra_link_args=extra_link_args,
py_limited_api=True,
),
]
However, after upgrading to PyTorch2.7, there will be unknown descriptor like
~/miniforge3/envs/sgl/lib/python3.9/site-packages/torch/include/pybind11/pytypes.h:947:13: error: use of undeclared identifier 'PyInstanceMethod_Check'
947 | if (PyInstanceMethod_Check(value.ptr())) {
| ^
~/miniforge3/envs/sgl/lib/python3.9/site-packages/torch/include/pybind11/pytypes.h:948:21: error: use of undeclared identifier 'PyInstanceMethod_GET_FUNCTION'
948 | value = PyInstanceMethod_GET_FUNCTION(value.ptr());
| ^
~/miniforge3/envs/sgl/lib/python3.9/site-packages/torch/include/pybind11/pytypes.h:949:20: error: use of undeclared identifier 'PyMethod_Check'
949 | } else if (PyMethod_Check(value.ptr())) {
| ^
~/miniforge3/envs/sgl/lib/python3.9/site-packages/torch/include/pybind11/pytypes.h:950:21: error: use of undeclared identifier 'PyMethod_GET_FUNCTION'
950 | value = PyMethod_GET_FUNCTION(value.ptr());
| ^
~/miniforge3/envs/sgl/lib/python3.9/site-packages/torch/include/pybind11/pytypes.h:1261:57: error: use of undeclared identifier 'PyListObject'
1261 | sequence_fast_readonly(handle
93D9
obj, ssize_t n) : ptr(PySequence_Fast_ITEMS(obj.ptr()) + n) {}
But if we set py_limited_api=False
, the issue gone.
Versions
Collecting environment information...
PyTorch version: 2.7.0+cpu
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.5 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.31.2
Libc version: glibc-2.35
Python version: 3.10.0 | packaged by conda-forge | (default, Nov 20 2021, 02:24:10) [GCC 9.4.0] (64-bit runtime)
Python platform: Linux-5.15.0-73-generic-x86_64-with-glibc2.35
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 52 bits physical, 57 bits virtual
Byte Order: Little Endian
CPU(s): 192
On-line CPU(s) list: 0-191
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8468V
CPU family: 6
Model: 143
Thread(s) per core: 2
Core(s) per socket: 48
Socket(s): 2
Stepping: 8
Frequency boost: enabled
CPU max MHz: 2401.0000
CPU min MHz: 800.0000
BogoMIPS: 4800.00
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cat_l2 cdp_l3 invpcid_single intel_ppin cdp_l2 ssbd mba ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local split_lock_detect avx_vnni avx512_bf16 wbnoinvd dtherm ida arat pln pts avx512vbmi umip pku ospke waitpkg avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq la57 rdpid bus_lock_detect cldemote movdiri movdir64b enqcmd fsrm md_clear serialize tsxldtrk pconfig arch_lbr amx_bf16 avx512_fp16 amx_tile amx_int8 flush_l1d arch_capabilities
L1d cache: 4.5 MiB (96 instances)
L1i cache: 3 MiB (96 instances)
L2 cache: 192 MiB (96 instances)
L3 cache: 195 MiB (2 instances)
NUMA node(s): 2
NUMA node0 CPU(s): 0-47,96-143
NUMA node1 CPU(s): 48-95,144-191
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] torch==2.6.0+cpu
[pip3] torchao==0.9.0
[pip3] torchaudio==2.6.0a0+c670ad8
[pip3] torchdata==0.11.0
[pip3] torchtext==0.16.0a0+b0ebddc
[pip3] torchvision==0.21.0+cpu
[pip3] triton==3.1.0
[conda] numpy 1.26.4 pypi_0 pypi
[conda] torch 2.7.0+cpu pypi_0 pypi
[conda] torchao 0.9.0 pypi_0 pypi
[conda] torchaudio 2.6.0a0+c670ad8 pypi_0 pypi
[conda] torchdata 0.11.0 pypi_0 pypi
[conda] torchtext 0.16.0a0+b0ebddc pypi_0 pypi
[conda] torchvision 0.21.0+cpu pypi_0 pypi
[conda] triton 3.1.0 pypi_0 pypi
@mingfeima @EikanWang for awareness
Metadata
Metadata
Assignees
Labels
module: cpp-extensionsRelated to torch.utils.cpp_extensionRelated to torch.utils.cpp_extensionmodule: regressionIt used to work, and now it doesn'tIt used to work, and now it doesn'ttriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module