8000 Strip extra leading slashes in `/etc/localtime` by akx · Pull Request #1165 · python-babel/babel · GitHub
[go: up one dir, main page]
Skip to content

Strip extra leading slashes in /etc/localtime #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2025
Merged

Strip extra leading slashes in /etc/localtime #1165

merged 2 commits into from
Jan 10, 2025

Conversation

akx
Copy link
Member
@akx akx commented Jan 9, 2025 •
edited
Loading

Fixes #990

Closes #1006 (supersedes it)
Closes #1035 (supersedes it)

@codecov Codecov
Copy link
codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (6bbdc0e) to head (fb28638).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1165   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files          27       27           
  Lines        4638     4654   +16     
=======================================
+ Hits         4235     4250   +15     
- Misses        403      404    +1
Flag Coverage Δ
macos-14-3.10 90.33% <100.00%> (+0.01%) ⬆️
macos-14-3.11 90.26% <100.00%> (+0.01%) ⬆️
macos-14-3.12 90.48% <100.00%> (+0.01%) ⬆️
macos-14-3.13 90.48% <100.00%> (+0.01%) ⬆️
macos-14-3.8 90.19% <100.00%> (+0.01%) ⬆️
macos-14-3.9 90.26% <100.00%> (+0.01%) ⬆️
macos-14-pypy3.10 90.33% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.10 90.35% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.11 90.28% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.12 90.50% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.13 90.50% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.8 90.21% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.9 90.28% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-pypy3.10 90.35% <100.00%> (+0.01%) ⬆️
windows-2022-3.10 90.36% <0.00%> (+0.01%) ⬆️
windows-2022-3.11 90.29% <0.00%> (+0.01%) ⬆️
windows-2022-3.12 90.51% <0.00%> (+0.01%) ⬆️
windows-2022-3.13 90.51% <0.00%> (+0.01%) ⬆️
windows-2022-3.8 90.33% <0.00%> (+0.01%) ⬆️
windows-2022-3.9 90.29% <0.00%> (+0.01%) ⬆️
windows-2022-pypy3.10 90.36% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx marked this pull request as ready for review January 9, 2025 12:40
@akx akx requested a review from tomasr8 January 9, 2025 12:40
@akx akx added this to the Babel 2.17 milestone Jan 9, 2025
tomasr8
tomasr8 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member
@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akx @tomasr8
Assert non-noneness!
fb28638 
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@akx akx merged commit c2b397e into master Jan 10, 2025
26 checks passed
@akx akx deleted the iss-990 branch January 10, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Babel 2.17
Development

Successfully merging this pull request may close these issues.

Crash with double-slashes in /etc/localtime on Python 3.9
2 participants
@akx @tomasr8
0