Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
CC @notatallshaw for eddb655 (I think). |
|
@henryiii ah, thanks for the duplication catches, I went through several rounds of adding more tests and just coming up with any edge case I could, so it doesn't surprise me a few were duplicates. I added this group for pip (pypa/pip#12894), I do think it's worth going the lint.flake8-pytest-style options and making sure you agree with each of them or think some are worth changing from the defaults. |
|
I do disagree with some of the PT checks; I was assuming we could turn them off if they came up in the future. "PT013" is incorrect if you want to import classes for typing (and IMO, |
|
And I do like the tuple better than csv for multiple parameters in parametrization; I think most of us picked up the csv style from old examples. I think that's the only one significantly different than the defaults in that PR. |
Yeah, I chose the setting for pip, including setting csv, based on keeping the diff as small as possible for the PR, I wasn't advocating for the same choices I made in that PR, just that it's worth reviewing the options. |
Found several issues: duplicated test cases (second commit), and test code that never ran (and was incorrect) (third commit). The final commit improves the tests by making sure the ValueError's raised are correct.