Remove custom MRO implementation of Pydantic models #11184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer necessary since #10666 was introduced.
Deploying pydantic-docs with
|
| Latest commit: |
6adc9c3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6df86b72.pydantic-docs.pages.dev |
| Branch Preview URL: | https://revert-mro.pydantic-docs.pages.dev |
|
I believe this should be backported, as it fixes #11042 which was a regression. |
5 tasks
|
Generally, I approve of this approach, as discussed in #10666. I think that the less we can manipulate the MRO, the better, as it introduces a pretty complex internal pattern that's hard to maintain. That being said, I think we should get buy in from @kc0506 and @dmontagu, as they were pretty involved in the addition of this custom MRO implementation. Happy to do another patch 2.10 release with this fix, I've added the corresponding label. |
CodSpeed Performance ReportMerging #11184 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer necessary since #10666 was introduced.
Fixes #11183.
Fixes #11042.
Closes #11037.
Change Summary
Related issue number
Checklist