8000 Strip whitespaces on JSON Schema title generation by sydney-runkle · Pull Request #10404 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Strip whitespaces on JSON Schema title generation #10404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

Strip whitespaces on JSON Schema title generation #10404

merged 2 commits into from
Sep 13, 2024

Conversation

sydney-runkle
Copy link
Contributor

Fix #10397

8000
@sydney-runkle sydney-runkle added the change Suggested alteration to Pydantic, not a new feature nor a bug label Sep 13, 2024
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 13, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link
cloudflare-workers-and-pages bot commented Sep 13, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d91242b
Status: ✅  Deploy successful!
Preview URL: https://fca561ee.pydantic-docs.pages.dev
Branch Preview URL: https://strip.pydantic-docs.pages.dev

View logs

@Viicos Viicos changed the title Strip whitespace on title gen for json schema Strip whitespaces on JSON Schema title generation Sep 13, 2024
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Sep 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10404 will not alter performance

Comparing strip (d91242b) with main (07bcf00)

Summary

✅ 49 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@sydney-runkle sydney-runkle merged commit d08eddf into main Sep 13, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the strip branch September 13, 2024 14:00
@sydney-runkle sydney-runkle added relnotes-change Used for changes to existing functionality which don't have a better categorization. and removed change Suggested alteration to Pydantic, not a new feature nor a bug relnotes-fix Used for bugfixes. labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos approved these changes

Assignees
No one assigned
Labels
relnotes-change Used for changes to existing functionality which don't have a better categorization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

model_json_schema() generates an unexpected leading space in title when using a serialization_alias with a _ prefix
2 participants
@sydney-runkle @Viicos
0