Comparing changes
Open a pull request
- 13 commits
- 46 files changed
- 9 contributors
Commits on May 8, 2023
-
-
Merge pull request #12717 from protocolbuffers/23.x-202305081751
Update version numbers for 23.0 release
Commits on May 9, 2023
-
This crash was due to the fact that we were passing `nullptr` as a `const char*` parameter and relying on that implicitly converting into an empty `absl::string_view`. `absl::string_view` supports that functionality, but starting with C++17 its behavior changes since it's just a type alias for `std::string_view`. `std::string_view` does not have any special conversion for nullptr and so we were just getting crashes. PiperOrigin-RevId: 530431663
-
This also adds tests for C++17 and C++20 to prevent further regressions. PiperOrigin-RevId: 530693318
-
Merge pull request #12743 from protocolbuffers/gcc-23
Backport GCC tests+fixes
Commits on May 12, 2023
-
fix: avoid warnings with MSVC (#12762)
In both cases a `size_t` was being converted to a `uint32_t`. These headers are used from application code, or at least from generated code, and the application may be compiling with more warnings enabled than normal. Closes #12762 COPYBARA_INTEGRATE_REVIEW=#12762 from coryan:fix-avoid-warnings-with-MSVC 5ba6b5d PiperOrigin-RevId: 531506224
-
Merge pull request #12775 from fowles/23.x
fix: avoid warnings with MSVC (#12762)
Commits on May 15, 2023
-
[C#] Replace regex that validates descriptor names (#12174)
This PR replaces the descriptor name validation regex with a validation method. This change allows the `System.Text.RegularExpressions` engine to be trimmed away in published apps that do standard protobuf serialization. There are some other usages of `Regex` in Google.Protobuf, but they in `JsonParser`. They are only included in a published app if `JsonParser` is used. Another benefit is a slightly faster app startup time. The removed regex was compiled, which has a high-ish fixed cost. cc @jskeet @jtattermusch Closes #12174 COPYBARA_INTEGRATE_REVIEW=#12174 from JamesNK:jamesnk/remove-regex 9d065a3 PiperOrigin-RevId: 532210203
-
Add a check for minimum supported Abseil version.
PiperOrigin-RevId: 532235063
-
Add a workaround for GCC constexpr bug
This turns the constexpr constructors into templates to silence errors when constexpr isn't valid. We are also switching to 12.2 for GCC/cmake tests to prevent regressions (9.5 and 13.1 are already tested by GCC/bazel tests). Fixes #12807 PiperOrigin-RevId: 532258101
Commits on May 16, 2023
-
Merge pull request #12825 from protocolbuffers/fixes-23
Backport fixes for 23.x
-
-
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.23.0...v3.23.1