histograms: Add timer to reset ASAP after bucket limiting has happened #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1248. See issue description for all the details. Signed-off-by: beorn7 <beorn@grafana.com>
|
@bwplotka @ArthurSens could you have a look at this? It fixes a rather annoying bug. |
|
Yes, will do! I returned from a 1 week PTO today, I'll schedule some time today or tomorrow to take a look at this PR |
bwplotka
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
It looks good to me, thanks! 💪🏽
Was just looking at this.
If want to help still @ArthurSens - we need to merge #1366 and figure out why test fails. It's security upgrade. 🤗
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1248. See issue description for all the details.