8000 Update tests against Relay by yatsukhnenko · Pull Request #1537 · predis/predis · GitHub
[go: up one dir, main page]
Skip to content

Update tests against Relay #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

Update tests against Relay #1537

merged 2 commits into from
May 12, 2025

Conversation

yatsukhnenko
Copy link
Contributor
@yatsukhnenko yatsukhnenko commented May 6, 2025 •
edited
Loading

Revisit relay-incompatible tests

@yatsukhnenko yatsukhnenko force-pushed the main branch 3 times, most recently from 8ff5b3a to e63f9b1 Compare May 6, 2025 13:55
@coveralls
Copy link
coveralls commented May 6, 2025 •
edited
Loading

Coverage Status

coverage: 92.675% (+0.01%) from 92.662%
when pulling 6bbd1c4 on yatsukhnenko:main
into 3cc3547 on predis:main.

@yatsukhnenko yatsukhnenko marked this pull request as ready for review May 6, 2025 16:21
@yatsukhnenko yatsukhnenko requested a review from tillkruss as a code owner May 6, 2025 16:21
tillkruss
tillkruss requested changes May 6, 2025
View reviewed changes
Copy link
Member
@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like only a few cluster failures. This is great!

@yatsukhnenko
Copy link
Contributor Author

It is because of unstable GitHub CI, try to re-run failed job

@tillkruss
Copy link
Member

It is because of unstable GitHub CI, try to re-run failed job

I re-ran them, still getting the Connection refused errors. Can we use a sleep or ignore these tests?

@tillkruss tillkruss requested a review from vladvildanov May 8, 2025 15:38
vladvildanov
vladvildanov reviewed May 12, 2025
View reviewed changes
@tillkruss tillkruss merged commit 9b1c6d2 into predis:main May 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yatsukhnenko @coveralls @tillkruss @vladvildanov
0