fix(deps): Apply JSX tranform changes to missed demos and examples#11679
fix(deps): Apply JSX tranform changes to missed demos and examples#11679thatblindgeye merged 3 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-11679.surge.sh A11y report: https://patternfly-react-pr-11679-a11y.surge.sh |
There was a problem hiding this comment.
Looks like there's one case of React.Fragment still being used in the PaginatedTable jsx file, under RTL demos. And since you had updated a comment to remove React., the Alert component's actionLinks description could be updated similarly (from "...in an array or React.Fragment" to "...in an array or React fragment"
The CustomMenus md demo file also needs useEffect added to the import statement.
There was a problem hiding this comment.
Outside of the aforementioned bits, I didn't see anything else that looked out of place so the rest lgtm.
I am a little curious why React.JSX.Element works without an import now, unless we import it globally elsewhere?
It's because TypeScript recognizes |
aec5ddb to
78f8c85
Compare
|
@thatblindgeye The latest changes should resolve those issues, plus a few more that were related to importing |
What: Closes #11658
This fixes all remaining issues related to the JSX transform changes that were made in #11582, specifically, the demos and examples that were either missed during the original sweep through the source, or were edge cases to the original scripts that were run.
All demos and examples should now work as expected, and they should not throw any errors when run or when opened in an IDE.
Edit: These changes will also resolve #11598, #11651, and #11652.