E52C Refactor(DataList): removed aria-labelledby and aria-selected by Mash707 · Pull Request #11569 · patternfly/patternfly-react · GitHub
[go: up one dir, main page]
Skip to content

Refactor(DataList): removed aria-labelledby and aria-selected#11569

Merged
thatblindgeye merged 3 commits intopatternfly:mainfrom
Mash707:removing-aria-from-datalist
Mar 4, 2025
Merged

Refactor(DataList): removed aria-labelledby and aria-selected#11569
thatblindgeye merged 3 commits intopatternfly:mainfrom
Mash707:removing-aria-from-datalist

Conversation

@Mash707
Copy link
Contributor
@Mash707 Mash707 commented Feb 26, 2025

Closes #11391

@Mash707
Copy link
Contributor Author
Mash707 commented Feb 26, 2025

Hi @thatblindgeye Have a look, let me know of any improvements.
Thank You!

@patternfly-build
Copy link
Collaborator
patternfly-build commented Feb 26, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11569.surge.sh

A11y report: https://patternfly-react-pr-11569-a11y.surge.sh

@Mash707 Mash707 force-pushed the removing-aria-from-datalist branch from 688a12d to a690019 Compare February 27, 2025 18:55
@Mash707 Mash707 force-pushed the removing-aria-from-datalist branch from a690019 to b7825c9 Compare February 27, 2025 19:20
@Mash707 Mash707 changed the title Removing aria labelling and aria-selected from li elements Refactor(DataList): removed aria-labelledby and aria-selected Feb 27, 2025
thatblindgeye
thatblindgeye requested changes Mar 3, 2025
View reviewed changes
Copy link
Contributor
@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're removing the aria-labelledby on the list item, we should update the prop description for aria-labelledby to something more fitting to it's purpose, maybe something like, "Adds an accessible name to the selectable input if one is rendered."

We should open a followup issue to rename this prop to selectableInputAriaLabelledby in a breaking change as well. Would you want to open a followup for this?

@Mash707
Copy link
Contributor Author
Mash707 commented Mar 3, 2025

I have updated the prop description.

We should open a followup issue to rename this prop to selectableInputAriaLabelledby in a breaking change as well. Would you want to open a followup for this?

Sure I'll open a followup issue for this.

@Mash707 Mash707 requested a review from thatblindgeye March 3, 2025 13:54
@Mash707 Mash707 mentioned this pull request Mar 3, 2025
Open
@thatblindgeye thatblindgeye merged commit 6bb9f35 into patternfly:main Mar 4, 2025
13 checks passed
@patternfly-build
Copy link
Collaborator
patternfly-build commented Mar 4, 2025

Your changes have been released in:

  • @patternfly/react-code-editor@6.2.0-prerelease.28
  • @patternfly/react-core@6.2.0-prerelease.26
  • @patternfly/react-docs@7.2.0-prerelease.43
  • @patternfly/react-drag-drop@6.2.0-prerelease.28
  • @patternfly/react-integration@6.0.0-prerelease.27
  • demo-app-ts@6.0.0-prerelease.76
  • @patternfly/react-table@6.2.0-prerelease.27
  • @patternfly/react-templates@6.2.0-prerelease.27

Thanks for your contribution! 🎉

@Mash707 Mash707 deleted the removing-aria-from-datalist branch March 6, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataList - aria labeling and aria-selected should be removed from li elements

4 participants

@Mash707 @patternfly-build @nicolethoen @thatblindgeye
0