chore(Routers): updated react/router and removed reach/router in examples#11545
Merged
mfrances17 merged 6 commits intopatternfly:mainfrom Feb 24, 2025
Merged
chore(Routers): updated react/router and removed reach/router in examples#11545mfrances17 merged 6 commits intopatternfly:mainfrom
mfrances17 merged 6 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11545.surge.sh A11y report: https://patternfly-react-pr-11545-a11y.surge.sh |
kmcfaul
approved these changes
Feb 20, 2025
Contributor
There was a problem hiding this comment.
LGTM
Want to double check, do we have an issue open in org to remove reach/router from the deps as well?
mfrances17
suggested changes
Feb 20, 2025
Contributor
There was a problem hiding this comment.
One small suggestion for a quick change to package.json, otherwise LGTM.
6027e03 to
a983541
Compare
Contributor
Author
@kmcfaul doesn't look like it. Was that something we planned to do? Think reach/router is being used a bit more than it was here in React, but can't 100% recall the convo we've had regarding the dep. |
mfrances17
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #8980, closes #11172
For the reach/router updates, I removed any specific examples/demos and instead added a section for using router links, including addinga section to the Menu page. Was considering instead just adding an example that showed how to render a custom component and mentioning router links being a use case, but wasn't sure if that would be as eye catching as a "Using router links" section. No strong opinion, though, if we would want to instead have a "Custom component/render" example and just have the example description note router links being a use case.
Also wondering if we should include this verbiage on the Dropdown page as well, or if Menu is enough.
Additional issues: