8000 fix(label-group): truncate labels within label-group by sg00dwin · Pull Request #7176 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

fix(label-group): truncate labels within label-group#7176

Merged
mcoker merged 1 commit intopatternfly:mainfrom
sg00dwin:7104-labelgroup-truncation
Nov 13, 2024
Merged

fix(label-group): truncate labels within label-group#7176
mcoker merged 1 commit intopatternfly:mainfrom
sg00dwin:7104-labelgroup-truncation

Conversation

@sg00dwin
Copy link
Contributor
@sg00dwin sg00dwin commented Oct 24, 2024 •
edited
Loading

@patternfly-build
Copy link
Collaborator
patternfly-build commented Oct 24, 2024 •
edited
Loading

Preview: https://patternfly-pr-7176.surge.sh

A11y report: https://patternfly-pr-7176-a11y.surge.sh

@mcoker mcoker requested review from mcoker and srambach October 25, 2024 19:53
mattnolting
mattnolting approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@sg00dwin sg00dwin force-pushed the 7104-labelgroup-truncation branch from a2eca8e to 91c1a7b Compare October 31, 2024 04:08
@srambach
Copy link
Member
srambach commented Nov 6, 2024 •
edited
Loading

What do you think about a min-width somewhere to avoid the labels shrinking to nothing? Maybe something along the lines of 4em or so, on the label?

image

@sg00dwin sg00dwin force-pushed the 7104-labelgroup-truncation branch from 91c1a7b to 803f95d Compare November 7, 2024 18:36
@sg00dwin
Copy link
Contributor Author
sg00dwin commented Nov 7, 2024 •
edited
Loading

What do you think about a min-width somewhere to avoid the labels shrinking to nothing? Maybe something along the lines of 4em or so, on the label?

Added a min-width of 3em which matches a 4 character width.

srambach
srambach approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷️ 👍🏻 I was trying to think of how we could use the existing spacing to create the min-width but I like this since we don't know for sure if there's an icon, etc.

@mcoker mcoker merged commit 5e934d0 into patternfly:main Nov 13, 2024
@mcoker mcoker mentioned this pull request Nov 13, 2024
Closed
@patternfly-build
Copy link
Collaborator
patternfly-build commented Nov 19, 2024

🎉 This PR is included in version 6.1.0-prerelease.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Dec 5, 2024
Merged
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnolting mattnolting mattnolting approved these changes

@srambach srambach srambach approved these changes

@mcoker mcoker Awaiting requested review from mcoker

Assignees

@mattnolting mattnolting

@mcoker mcoker

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - [LabelGroup] - labels do not get truncated

5 participants

@sg00dwin @patternfly-build @srambach @mattnolting @mcoker
0