8000 fix(nuxt): pass statusMessage to error.vue by jeffreyvdhondel · Pull Request #31761 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxt): pass statusMessage to error.vue #31761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

fix(nuxt): pass statusMessage to error.vue #31761

merged 1 commit into from
Apr 14, 2025

Conversation

jeffreyvdhondel
Copy link
Contributor

📚 Description

nitro default error hander doesn't return error.statusMessage (as expected) as an API response in production, but we do want to pass this along when rendering error.vue so user can choose whether to use this data in rendering/handling the page

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Apr 10, 2025

Walkthrough

The changes add an extra assignment within the error handling logic of the function in the error handler. Specifically, a line has been introduced to ensure that if the property statusMessage in the error object is not already defined, it receives the value from the original error's statusMessage. The rest of the function remains as it was, continuing to process JSON requests, utilise the default error handler, and manage response headers and body in the same manner. No modifications were made to the declarations of any exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b0b1bb6 and 770f63f.

📒 Files selected for processing (1)
  • packages/nuxt/src/core/runtime/nitro/handlers/error.ts (1 hunks)
🔇 Additional comments (1)
packages/nuxt/src/core/runtime/nitro/handlers/error.ts (1)

38-38: Excellent addition for enhancing error information.

The change ensures the statusMessage from the original error is preserved in the error object passed to the error page. This directly addresses the PR's objective of making the statusMessage available in the error.vue component, allowing users to access this information when rendering error pages.

This implementation is consistent with how other properties (message and data) are handled in the same block, using the nullish coalescing assignment operator to set values only when they're not already defined.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@31761

nuxt

npm i https://pkg.pr.new/nuxt@31761

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@31761

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@31761

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@31761

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@31761

commit: 770f63f

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Apr 10, 2025

CodSpeed Performance Report

Merging #31761 will not alter performance

Comparing jeffreyvdhondel:fix/pass-error-statusMessage-to-error.vue (770f63f) with main (8431235)

Summary

✅ 10 untouched benchmarks

@danielroe danielroe merged commit c3dea6a into nuxt:main Apr 14, 2025
47 checks passed
@github-actions github-actions bot mentioned this pull request Apr 14, 2025
Merged
danielroe pushed a commit that referenced this pull request Apr 14, 2025
@jeffreyvdhondel @danielroe
fix(nuxt): always pass statusMessage when rendering html error (#31761
0ccb236 
)
@github-actions github-actions bot mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreyvdhondel @danielroe
0