Rewrite DnsQueryContextManager to simplify and make it easier to debug #13440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We are currently investigate an issue where it seems that we receive un unexpected hostname in the response. To make it easier to debug let us simplify the DnsQueryContextManager Modifications: - Move extra logic to internal class - Add asserts Result: Cleanup
hyperxpro
suggested changes
Jun 13, 2023
resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Jun 13, 2023
Contributor
|
Seems like a common ground in dns querying. I have not read the code, have the questions in response been validated？ |
hyperxpro
approved these changes
Jun 14, 2023
normanmaurer
added a commit
that referenced
this pull request
Jun 15, 2023
#13440) Motivation: We are currently investigate an issue where it seems that we receive un unexpected hostname in the response. To make it easier to debug let us simplify the DnsQueryContextManager Modifications: - Move extra logic to internal class - Add asserts Result: Cleanup
trustin
reviewed
Jun 16, 2023
Member
There was a problem hiding this comment.
Belated LGTM. Thanks, @normanmaurer! 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We are currently investigate an issue where it seems that we receive un unexpected hostname in the response. To make it easier to debug let us simplify the DnsQueryContextManager
Modifications:
Result:
Cleanup