8000 fix: stop spinner after `netlify login` (#7296) · netlify/cli@9dfb71a · GitHub 8000
[go: up one dir, main page]

Skip to content

Commit 9dfb71a

Browse files
ndhouleserhalp
andauthored
fix: stop spinner after netlify login (#7296)
Currently, when the `netlify login` command successfully finishes or fails, we fail to stop the spinner correctly. The user must then SIGINT/Ctrl-C to exit. This change fixes that issue. Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>
1 parent 47242ce commit 9dfb71a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/utils/command-helpers.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import WSL from 'is-wsl'
1212
import debounce from 'lodash/debounce.js'
1313
import terminalLink from 'terminal-link'
1414

15-
import { clearSpinner, startSpinner } from '../lib/spinner.js'
15+
import { startSpinner } from '../lib/spinner.js'
1616

1717
import getGlobalConfigStore from './get-global-config-store.js'
1818
import getCLIPackageJson from './get-cli-package-json.js'
@@ -119,7 +119,8 @@ export const pollForToken = async ({
119119
return logAndThrowError(error_)
120120
}
121121
} finally {
122-
clearSpinner({ spinner })
122+
spinner.stop()
123+
spinner.clear()
123124
}
124125
}
125126
/**

0 commit comments

Comments
 (0)
0