E592 Improve types a bit for addSource and getSource by HarelM · Pull Request #4616 · maplibre/maplibre-gl-js · GitHub
[go: up one dir, main page]
Skip to content

Improve types a bit for addSource and getSource #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2024
Merged

Improve types a bit for addSource and getSource #4616

merged 4 commits into from
Aug 28, 2024

Conversation

HarelM
Copy link
Collaborator
@HarelM HarelM commented Aug 27, 2024 •
edited
Loading

Launch Checklist

Improve addSource and getSource typings.

Fixes #4211

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link
codecov-commenter commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (8cbd4f1) to head (d5d7fe8).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4616      +/-   ##
==========================================
+ Coverage   87.80%   87.83%   +0.03%     
==========================================
  Files         247      247              
  Lines       33618    33621       +3     
  Branches     2178     2172       -6     
==========================================
+ Hits        29518    29532      +14     
+ Misses       3118     3111       -7     
+ Partials      982      978       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM requested review from sbachinin and kubapelc August 27, 2024 14:23
neodescis
neodescis reviewed Aug 27, 2024
View reviewed changes
@HarelM HarelM enabled auto-merge (squash) August 28, 2024 14:23
@HarelM HarelM merged commit d60007b into main Aug 28, 2024
15 checks passed
@HarelM HarelM deleted the improve-map-source-typescript-api branch August 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neodescis neodescis neodescis approved these changes

@sbachinin sbachinin Awaiting requested review from sbachinin

@kubapelc kubapelc Awaiting requested review from kubapelc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarelM @codecov-commenter @neodescis
0