Fix: unable to remove listener with layer(s) registered with Map#once #4592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaszek
commented
Aug 24, 2024
| for (const key in delegatedListener.delegates) { | ||
| const delegate: Delegate = delegatedListener.delegates[key]; | ||
| delegatedListener.delegates[key] = (...args: Parameters<Delegate>) => { | ||
| this._removeDelegatedListener(type, layerIds, listener); |
There was a problem hiding this comment.
My concern is that in this._removeDelegatedListener the Map#off is called. On the other hand here we have reference to delegate, so it shouldn't harm. As a solution for that, we can add parameter, to skip calling off in this._removeDelegatedListener.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4592 +/- ##
==========================================
- Coverage 87.88% 87.87% -0.02%
==========================================
Files 247 247
Lines 33601 33613 +12
Branches 2336 2339 +3
==========================================
+ Hits 29530 29536 +6
+ Misses 3108 3105 -3
- Partials 963 972 +9 ☔ View full report in Codecov by Sentry. |
HarelM
reviewed
Aug 25, 2024
HarelM
reviewed
Aug 25, 2024
HarelM
reviewed
Aug 26, 2024
…o fix-unable-to-remove-once-listener-with-layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue, that Map#off does not deregister an event registered with Map#once, when layer(s) are provided.
Launch Checklist
CHANGELOG.mdunder the## mainsection.