8000 Fix miscellaneous errors with old Laravel versions by jessarcher · Pull Request #212 · laravel/nightwatch · GitHub
[go: up one dir, main page]
Skip to content

Fix miscellaneous errors with old Laravel versions #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 1, 2025
Merged

Fix miscellaneous errors with old Laravel versions #212

merged 25 commits into from
Jul 1, 2025

Conversation

jessarcher
Copy link
Member
@jessarcher jessarcher commented Jun 30, 2025 •
edited
Loading

composer install does not appear to respect the COMPOSER_PREFER_LOWEST=1/--prefer-lowest setting - it's a feature of composer update.

This PR updates our CI tests to use composer update, and also displays (prefer lowest) in the job name to help differentiate them.

It also fixes several issues we discovered in the process.

jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
@jessarcher jessarcher marked this pull request as ready for review June 30, 2025 05:16
@jessarcher jessarcher changed the title Fix testing with "prefer lowest" Fix miscellaneous errors with old Laravel versions Jun 30, 2025
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
jessarcher
jessarcher commented Jun 30, 2025
View reviewed changes
@jessarcher jessarcher enabled auto-merge (squash) June 30, 2025 13:04
@jessarcher jessarcher merged commit ddd38fa into 1.x Jul 1, 2025
25 checks passed
@jessarcher jessarcher deleted the prefer-lowest-fix branch July 1, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timacdonald timacdonald timacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessarcher @timacdonald
0