[12.x] Address Model@relationLoaded when relation is null #55531
Conversation
|
Just updated to 12.10.1 and got this error 😄 Thank you for quick fix. |
|
Thank you! However, it seems that the issue still persists after this PR. I have the following example to reproduce it: $model = new class extends Model {};
$model->setRelations(['many' => ['one', 'two', 'three' => 84]]);
$result = $this->getAttribute('many.three');
// In version 12.10.1 (and with this PR), this throws:
// Error: Call to a member function relationLoaded() on null
// Previously, this would return null. |
|
Can we just revert everything related to this? |
I guess so. Mind both my PRs were trying to fix the original one. Do you want me to send a reversal PR? |
|
I would like to keep the feature if it can work without issue, it would be useful. |
|
@nicekiwi it was already reverted in 12.0.2 I agree it is useful, but it had too many oversights on edge-cases. (Granted that it was very hard for the original author to think about them all in advance.) You can try sending a PR that addresses these edge cases. You can either build up from the reverted code and consider the bug reports, or start from scratch. An alternative is creating a package that provides an override for that method. Even as a trait, as it would be added by a subclass from the model, it wouldn't conflict with the |
This is a fix after PR #55519
As noted by @nicekiwi on this comment:
#55519 (comment)
When a relation returns
null, for example$user->address, the$relatedModelarray introduced on PR #55519, becomes[null].That can lead to the following
foreachto be executed, and fail as:Error: Call to a member function relationLoaded() on nullThis PR:
array_filter()call to ensure nonulls are present