Defer dataloader integration#3639
Merged
andimarek merged 15 commits intographql-java:masterfrom Aug 29, 2024
Merged
Conversation
felipe-gdr
commented
Jun 20, 2024
| incrementalSupport << [true, false] | ||
| } | ||
|
|
||
| def "chainedInstrumentation: data loader will not work with deferred queries"() { |
Member
Author
There was a problem hiding this comment.
Moved defer+data loader tests to its own file
felipe-gdr
commented
Aug 1, 2024
| } | ||
| """ | ||
|
|
||
| static def expectedInitialDeferredData = [ |
Member
Author
There was a problem hiding this comment.
Moved the defer tests into their own test class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for a quick and dirty solution for integrating
@deferand data loaders, which will unblock further work.This implementation will not try to optimise dispatches at all for deferred fields. It will simply always dispatch, which will inevitably result in more dispatches than necessary.
Dispatches for non-deferred fields will behave the same as before - i.e. in an optimal way.