Add toString() implementations for RawVariables and CoercedVariables classes#3629
Merged
bbakerman merged 1 commit intographql-java:masterfrom Jun 12, 2024
Conversation
Member
|
Thanks for this. Its a small change but all small changes help and I am a big beleiver in good toString() merthods especially when inside a debugger |
Contributor
Author
My pleasure. Thanks for being receptive to contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3628.
I have not bothered doing any unit tests of this very minor change, not least because best practices mean nobody should be relying on the output of a
toString()method, anyway. However, if you really want UTs for this, let me know and I can add them.I have deliberately not put a descriptive wrapper around the
toString()call to the internal object; but again, if you would prefer otherwise, please advise.Thanks in advance for your review.