AstPrinter: Empty types should not include braces {}#3619
Merged
dondonz merged 1 commit intographql-java:masterfrom Jun 11, 2024
Merged
AstPrinter: Empty types should not include braces {}#3619dondonz merged 1 commit intographql-java:masterfrom
{}#3619dondonz merged 1 commit intographql-java:masterfrom
Conversation
3de88f1 to
a9f53dd
Compare
bbakerman
approved these changes
Jun 6, 2024
Member
There was a problem hiding this comment.
Great to see you contributing again :)
Contributor
Author
🙏 but really it's all you and the other core contributors that keep this library in tip-top shape! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the latest version of the spec, empty types (input objects, object types) must be represented without curly braces, i.e the following is valid:
while the following technically isn't (note the
{}):Because of historical reasons,
graphql-javasupports parsing of both syntaxes. However itsAstPrinterprints the spec invalid form. While this is ok in systems wheregraphql-java's GraphQL parser is the only one in use, it fails in poly-parser systems where stricter (albeit spec-compliant) parsers might fail to parsegraphql-javaprinted SDL output.Approach
This PR updates the
AstPrinterto be spec-compliant, i.e serialize empty types, empty selection sets (although should never happen) without the{}.Follow ups
If there is interest, I can follow up with another PR that (while breaking backwards-compatibilty) will make the parser spec compliant as well, i.e only allow the form without braces
{}.