You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All pre-release tests are passing with protobuf 6.30.0 except test_iam_policy. This should be fixed before merging this PR to ensure that we have visibility of any new issues related to incremental changes of protobuf 6.x.
@parthea 8d437e4 there are some updates from owlbot removing code in existing files in our PRs(#1318).
This PR has the exact same change.
Do you know why is owlbot removing those code and adding those commits as part of our PRs? And will merging this PR fix this issue?
@harshachinta , Owlbot Post Processor didn't run in #1321. As a result, it wasn't clear that owlbot.py needed to be updated at the time of merging #1321. The changes in this PR will resolve the issue where owlbot is removing code in other PRs. In terms of next steps, we can either merge this PR, or revert #1321
@harshachinta , Owlbot Post Processor didn't run in #1321. As a result, it wasn't clear that owlbot.py needed to be updated at the time of merging #1321. The changes in this PR will resolve the issue where owlbot is removing code in other PRs. In terms of next steps, we can either merge this PR, or revert #1321
@parthea Could we merge this PR #1318 with owlbot changes. I realized that this PR needs more changes to fix the test_iam_policy tests. Meanwhile we would to merge the other PR
api: spannerIssues related to the googleapis/python-spanner API.size: sPull request size is small.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://pypi.org/project/protobuf/6.30.0/
See googleapis/gapic-generator-python#2347 for removing
devinsetup.pyAlso update
owlbot.pyas theOwlbot post processordidn't run in #1321 so it wasn't clear thatowlbot.pyneeded to be updated.