8000 fix: set `include` in `tool.setuptools.packages.find` by parthea · Pull Request #13662 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

fix: set include in tool.setuptools.packages.find #13662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

fix: set include in tool.setuptools.packages.find #13662

merged 1 commit into from
Mar 14, 2025
+1 −1

Conversation

parthea
Copy link
Contributor
@parthea parthea commented Mar 14, 2025 •
edited
Loading

This PR fixes an issue in googleapis-common-protos where excludes is set in tool.setuptools.packages.find, without specifying include which may cause strange installation behaviour as seen in this build log from PR #13657.

google-cloud-python/packages/googleapis-common-protos/pyproject.toml

Lines 53 to 54 in a2466af

[tool.setuptools.packages.find]
exclude = ["tests*", "testing*", "docs*"]

See the following from the log

2025-03-13T02:08:01.5380028Z       copying google/type/timeofday.proto -> build/lib/google/type
2025-03-13T02:08:01.5380508Z       copying google/type/timeofday_pb2.pyi -> build/lib/google/type
2025-03-13T02:08:01.5381044Z       copying google/longrunning/operations_proto.proto -> build/lib/google/longrunning
2025-03-13T02:08:01.5381779Z       copying google/longrunning/operations_proto_pb2.pyi -> build/lib/google/longrunning
2025-03-13T02:08:01.5382515Z       copying google/cloud/extended_operations.proto -> build/lib/google/cloud
2025-03-13T02:08:01.5383066Z       copying google/cloud/extended_operations_pb2.pyi -> build/lib/google/cloud
2025-03-13T02:08:01.5383725Z       copying google/logging/type/http_request.proto -> build/lib/google/logging/type
2025-03-13T02:08:01.5384343Z       copying google/logging/type/http_request_pb2.pyi -> build/lib/google/logging/type
2025-03-13T02:08:01.5384894Z       copying google/logging/type/log_severity.proto -> build/lib/google/logging/type
2025-03-13T02:08:01.5385554Z       copying google/logging/type/log_severity_pb2.pyi -> build/lib/google/logging/type
2025-03-13T02:08:01.5386189Z       copying google/gapic/metadata/gapic_metadata.proto -> build/lib/google/gapic/metadata
2025-03-13T02:08:01.5386932Z       copying google/gapic/metadata/gapic_metadata_pb2.pyi -> build/lib/google/gapic/metadata
2025-03-13T02:08:01.5387616Z       copying google/rpc/context/attribute_context.proto -> build/lib/google/rpc/context
2025-03-13T02:08:01.5388236Z       copying google/rpc/context/attribute_context_pb2.pyi -> build/lib/google/rpc/context
2025-03-13T02:08:01.5388920Z       copying google/rpc/context/audit_context.proto -> build/lib/google/rpc/context
2025-03-13T02:08:01.5389497Z       copying google/rpc/context/audit_context_pb2.pyi -> build/lib/google/rpc/context
2025-03-13T02:08:01.5390104Z       copying google/cloud/location/locations.proto -> build/lib/google/cloud/location
2025-03-13T02:08:01.5390777Z       copying google/cloud/location/locations_pb2.pyi -> build/lib/google/cloud/location
2025-03-13T02:08:01.5413887Z       copying build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib/build/lib....../lib/google/api

I've confirmed that setting include = ["google*"] for tool.setuptools.packages.find fixes the issue. See build log here from PR #13657.

We also do this in other packages:

google-cloud-python/packages/grpc-google-iam-v1/pyproject.toml

Lines 52 to 53 in a2466af

[tool.setuptools.packages.find]
include = ["google*"]

See https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration for more information on tool.setuptools.packages.find

@parthea parthea requested a review from a team as a code owner March 14, 2025 21:31
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2025
@vchudnov-g vchudnov-g merged commit c6a1588 into main Mar 14, 2025
20 checks passed
@vchudnov-g vchudnov-g deleted the fix-googleapis-common-protos branch March 14, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @vchudnov-g
0