Allow configuring CODEQL_THREADS with an env var #2891
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables configuring the number of CodeQL threads via an environment variable.
- Allows users to override the thread count using CODEQL_THREADS in the environment.
- Falls back to computing the thread value based on the "threads" input if the env var is not set.
There was a problem hiding this comment.
Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.
Can you try this alternate approach?
In the init/actions.yml file add default: "${{ env.CODEQL_THREADS }}" to the threads input. This should be sufficient.
Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated |
Great. Let me know if this works for you. Now that I'm engaged, I'll be able to respond more quickly to this PR. |
|
@aeisenberg lmk what you think 👍 |
|
@aeisenberg ah I don't think you can use env variable expressions in inputs |
This reverts commit df7d681.
|
Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that's being used elsewhere. |
Most of those examples commented out the |
|
In any case it probably makes sense to have the threads and ram behavior configuration be exactly the same so there aren't any surprises |
|
Thanks for the contribution @austinpray-mixpanel! Could you follow the instructions in https://github.com/github/codeql-action/blob/main/CONTRIBUTING.md#common-tasks to rebuild the project? |
|
@henrymercer done 👍 |
|
Thank you all! |
closes #2890
Merge / deployment checklist