8000 fix: `no-unused-vars` include caught errors pattern in report message by kirkwaiblinger · Pull Request #18609 · eslint/eslint · GitHub
[go: up one dir, main page]
Skip to content

fix: no-unused-vars include caught errors pattern in report message #18609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix: no-unused-vars include caught errors pattern in report message #18609

merged 2 commits into from
Jun 21, 2024

Conversation

kirkwaiblinger
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fix #18607

What changes did you make? (Give an overview)

Extracted report description inference to a common helper to reduce errors.

Depends on/blocked by #18608

Is there anything you'd like reviewers to focus on?

@kirkwaiblinger kirkwaiblinger requested a review from a team as a code owner June 19, 2024 23:09
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 19, 2024
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Jun 19, 2024
@netlify Netlify
Copy link
netlify bot commented Jun 19, 2024 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit e514097
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/667441ebe9b3650008ba484c

@kirkwaiblinger kirkwaiblinger force-pushed the caught-errors-for-written-but-not-read branch from 17eefe0 to cd59b01 Compare June 19, 2024 23:28
@mdjermanovic
Copy link
Member

#18608 has been merged now, but it caused merge conflicts here.

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Jun 20, 2024
@kirkwaiblinger kirkwaiblinger force-pushed the caught-errors-for-written-but-not-read branch from cd59b01 to d23dc2e Compare June 20, 2024 14:16
@kirkwaiblinger
Copy link
Contributor Author

@mdjermanovic updated 👍

mdjermanovic
mdjermanovic approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member
@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for one day in case anyone else would like to take a look.

@mdjermanovic mdjermanovic changed the title fix: [no-unused-vars] Include caught errors pattern in report message fix: no-unused-vars include caught errors pattern in report message Jun 20, 2024
@snitin315 snitin315 merged commit 21d3766 into eslint:main Jun 21, 2024
@kirkwaiblinger kirkwaiblinger deleted the caught-errors-for-written-but-not-read branch June 21, 2024 13:35
@kirkwaiblinger kirkwaiblinger mentioned this pull request Jun 25, 2024
Closed
@fasttime fasttime mentioned this pull request Jun 29, 2024
Merged
1 task
@abrahamguo abrahamguo mentioned this pull request Jul 9, 2024
Merged
6 tasks
@ekmixon ekmixon mentioned this pull request Jul 19, 2024
Open
This was referenced Jul 19, 2024
Merged
Open
@jamesleesaunders jamesleesaunders mentioned this pull request Jul 20, 2024
Merged
@lholmquist lholmquist mentioned this pull request Jul 20, 2024
Closed
@saidsef saidsef mentioned this pull request Jul 20, 2024
Closed
@drwho725 drwho725 mentioned this pull request Jul 20, 2024
Merged
@leoo1992 leoo1992 mentioned this pull request Jul 20, 2024
Merged
@hizumiaoba hizumiaoba mentioned this pull request Jul 20, 2024
Merged
@jadsongmatos jadsongmatos mentioned this pull request Jul 20, 2024
Merged
@lholmquist lholmquist mentioned this pull request Aug 20, 2024
Closed
@justkmode justkmode mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 21, 2024
Closed
Closed
Closed
@jamesleesaunders jamesleesaunders mentioned this pull request Aug 28, 2024
Closed
@lholmquist lholmquist mentioned this pull request Aug 31, 2024
Closed
@ekmixon ekmixon mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 3, 2024
Closed
Closed
@zntb zntb mentioned this pull request Sep 6, 2024
Merged
This was referenced Sep 14, 2024
Closed
Closed
Closed
Closed
@vinitkumar vinitkumar mentioned this pull request Sep 18, 2024
Merged
@lholmquist lholmquist mentioned this pull request Sep 19, 2024
Closed
This was referenced Sep 23, 2024
Open
Open
@lholmquist lholmquist mentioned this pull request Sep 28, 2024
Closed
This was referenced Sep 29, 2024
Merged
Closed
@lholmquist lholmquist mentioned this pull request Oct 1, 2024
Closed
@tygyh tygyh mentioned this pull request Oct 2, 2024
Closed
This was referenced Oct 2, 2024
Closed
Closed
@ebiz-markusrissmann ebiz-markusrissmann mentioned this pull request Oct 4, 2024
Open
@lholmquist lholmquist mentioned this pull request Oct 5, 2024
Closed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 19, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly contributor pool rule Relates to ESLint's core rules
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unused-vars] Error message doesn't inform about caught errors pattern when caught error is reassigned but not used
3 participants
@kirkwaiblinger @mdjermanovic @snitin315
0