buildx(history): check buildx version before exporting #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
@crazy-max I assume failing to export history record does not fail the action invocation?
No we catch the error and just warn: https://github.com/docker/build-push-action/blob/94f8f8c2eec4bc3f1d78c1755580779804cb87b2/src/main.ts#L169-L170 And even if it wasn't the case this would still not fail the build invocation as generating summary is done in post step of the action: https://github.com/docker/build-push-action/blob/94f8f8c2eec4bc3f1d78c1755580779804cb87b2/src/main.ts#L141-L144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes docker/build-push-action#1143
closes docker/build-push-action#1145
Build summary requires Buildx
dial-stdiocommand available since Buildx 0.13.0. This adds an extra check to make sure current Buildx version is supported before exporting.