8000 Fix unittest assert calls for Python 3.12 by cclauss · Pull Request #1930 · django-haystack/django-haystack · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unittest assert calls for Python 3.12 #1930

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Fix unittest assert calls for Python 3.12 #1930

merged 2 commits into from
Jan 1, 2024

Conversation

cclauss
Copy link
Contributor
@cclauss cclauss commented Dec 31, 2023 •
edited
Loading

Fix unittest assert calls for Python 3.12: https://docs.python.org/3/whatsnew/3.12.html#id3

  • Deprecated in Python 3.2 and removed in Python 3.12.

claudep
claudep requested changes Dec 31, 2023
View reviewed changes
@cclauss cclauss enabled auto-merge (squash) December 31, 2023 15:55
@cclauss cclauss requested a review from claudep December 31, 2023 15:55
@claudep claudep disabled auto-merge December 31, 2023 16:12
@cclauss
Copy link
Contributor Author
cclauss commented Jan 1, 2024

@claudep Why disable auto-merge on this PR? Is there something controversial about the proposed changes?

@claudep claudep merged commit 3a566a5 into django-haystack:master Jan 1, 2024
4 of 45 checks passed
@cclauss cclauss deleted the fix-unittest-assert-calls-for-Python-3.12 branch January 1, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep approved these changes

Assignees

@acdha acdha

@claudep claudep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @claudep @acdha
0